Remove redundant null-forgiving operator in MamJsonParser.ReadClassRewrites#11772
Merged
jonathanpeppers merged 2 commits intoJun 30, 2026
Merged
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove redundant null-forgiving operator in MamJsonParser.ReadClassRewrites
Remove redundant null-forgiving operator in MamJsonParser.ReadClassRewrites
Jun 27, 2026
simonrozsival
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant null-forgiving operator in MamJsonParser.ReadClassRewrites, aligning the implementation with the existing null-guard and the pattern used in ReadGlobalMethodCalls.
Changes:
- Remove the
!null-forgiving operator from theTryReadClassFromTocall afterclassRewritehas already been checked for null.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Utilities/MamJsonParser.cs | Removes a redundant null-forgiving operator in ReadClassRewrites to comply with the repo’s “no !” rule and reflect the existing null check. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
jonathanpeppers
approved these changes
Jun 30, 2026
rolfbjarne
approved these changes
Jun 30, 2026
dalexsoto
approved these changes
Jun 30, 2026
jonathanpeppers
deleted the
copilot/fix-reduntant-null-forgiving-operator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MamJsonParser.ReadClassRewritesused the!null-forgiving operator onclassRewrite, which is already proven non-null by theif (classRewrite == null) continue;guard immediately above. This violates the repo rule against using!and is redundant—the siblingReadGlobalMethodCallsmakes the identical call without it.Changes
!from theTryReadClassFromTocall inReadClassRewrites:No other lines changed. The out-of-scope
JsonNode.Parse ("{}")!inReadJsonwas left untouched.